Initial Drupal 12 support - #126
Conversation
…location for Drupal 12
|
@demeritcowboy I found that if hook_requirements() or hook_runtime_requirements() are present in civicrm.install, installing other modules fails. This will be breaking changes now, so maybe we give thought to a separate branch / version for D12. |
| $requirements = []; | ||
| // modified version of _civicrm_find_civicrm() from civicrm.install | ||
| // Move to a service? | ||
| $possible_paths = []; |
There was a problem hiding this comment.
Move to a service? This code is also needed in CivicrmInstallRequirements
|
|
||
| // Modification of _civicrm_setup() | ||
| // Move to a service? | ||
| if (defined('CIVI_SETUP')) { |
There was a problem hiding this comment.
Move to a service? This is also needed in CivicrmInstallRequirements
|
The PR for composer-compile-lib civicrm/composer-compile-lib#10 |
|
I created #127 to provide a more backward compatible option. It needs to be discussed, when to stop supporting Drupal 9/10, or even < 11.3 .. and be able to update this module to the latest architectural changes. If it was possible to do a separate repo for Drupal 11.3+ or 12+ .. then we could improve the module much more significantly. |
|
My two cents is that we need to support 10 for a bit but for 9 we should have dropped it a while ago. |
|
Up to you if you want to leave this open and come back to it when we're no longer supporting drupal 10-ish. |
2 participants
I have a working local D12/CiviCRM with:
civicrm/civicrm-core#35569
civicrm/civicrm-core#35570
civicrm/civicrm-core#35571
This PR
And a composer-compile-lib fork that just allows Symfony 8 - PR coming to that repo
See also https://lab.civicrm.org/dev/drupal/-/work_items/204